Skip to content

Enhance DefaultAttachmentsServiceHandler test coverage #794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Schmarvinius merged 3 commits into from
Apr 14, 2026
Merged

Enhance DefaultAttachmentsServiceHandler test coverage #794

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
31aa5c1
Enhance DefaultAttachmentsServiceHandler test coverage
Schmarvinius Apr 13, 2026
24d635e
Address review: remove duplicate tests, clean up unused variable
Schmarvinius Apr 13, 2026
a6e550a
Merge branch 'main' into enhance-default-handler-test-coverage
Schmarvinius Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions ...va/com/sap/cds/feature/attachments/service/handler/AttachmentsServiceImplHandlerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@
package com.sap.cds.feature.attachments.service.handler;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.when;
Expand All @@ -19,6 +21,7 @@
import com.sap.cds.reflect.CdsEntity;
import com.sap.cds.services.changeset.ChangeSetListener;
import com.sap.cds.services.impl.changeset.ChangeSetContextImpl;
import java.util.Collections;
import java.util.Map;
import java.util.Objects;
import org.junit.jupiter.api.AfterEach;
Expand Down Expand Up @@ -103,6 +106,38 @@ void malwareScannerRegisteredForEndOfTransaction() {
verify(malwareScanProvider).getChangeSetListener(entity, "contentId");
}

@Test
void createAttachment_emptyAttachmentIds_handlesGracefully() {
var createContext = AttachmentCreateEventContext.create();
createContext.setAttachmentIds(Collections.emptyMap());
createContext.setData(MediaData.create());
createContext.setAttachmentEntity(mock(CdsEntity.class));
ChangeSetContextImpl.open(false);

cut.createAttachment(createContext);

assertThat(createContext.getContentId())
.as("contentId should be null when Attachments.ID key is missing from attachmentIds")
.isNull();
assertThat(createContext.isCompleted()).isTrue();
}

@Test
void afterCreateAttachment_noChangeSetContext_throws() {
var entity = mock(CdsEntity.class);
when(malwareScanProvider.getChangeSetListener(any(), any()))
.thenReturn(mock(ChangeSetListener.class));
var createContext = AttachmentCreateEventContext.create();
createContext.setAttachmentIds(Map.of(Attachments.ID, "some-id"));
createContext.setData(MediaData.create());
createContext.setAttachmentEntity(entity);

cut.createAttachment(createContext);

assertThatThrownBy(() -> cut.afterCreateAttachment(createContext))
.isInstanceOf(NullPointerException.class);
}
Comment thread
Schmarvinius marked this conversation as resolved.

private void closeChangeSetContext() throws Exception {
var context = ChangeSetContextImpl.getCurrent();
if (Objects.nonNull(context)) {
Expand Down
Loading