Skip to content

Reduce cdsrc and clean up remnants#800

Open
Schmarvinius wants to merge 2 commits intomainfrom
cleanup
Open

Reduce cdsrc and clean up remnants#800
Schmarvinius wants to merge 2 commits intomainfrom
cleanup

Conversation

@Schmarvinius
Copy link
Copy Markdown
Collaborator

@Schmarvinius Schmarvinius commented Apr 14, 2026

Reduce .cdsrc Configuration and Clean Up Remnants

Refactor

♻️ Cleaned up leftover configuration and references related to the previous integration test structure, updating module exclusions and removing obsolete settings.

Changes

  • .github/workflows/pipeline.yml: Updated the Maven deploy command to exclude the renamed/restructured integration test modules (integration-tests/generic and integration-tests/mtx-local/srv) instead of the old integration-tests/srv.
  • .pipeline/config.yml: Updated Synopsys Detect (Black Duck) scan exclusions to reflect the new integration test module paths (integration-tests/generic, integration-tests/mtx-local/srv), replacing the old integration-tests/srv reference.
  • integration-tests/.cdsrc.json: Removed stale requires (persistent-outbox) and fiori (draft_messages) configuration entries, leaving only the build task definition.
  • integration-tests/srv/src/test/java/.../NonAttachmentCompositionDraftTest.java: Removed this test file as part of the integration test structure cleanup.
  • 🔄 Regenerate and Update Summary

📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!

PR Bot Information

Version: 1.20.11 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

  • Event Trigger: pull_request.opened
  • Output Template: Default Template
  • Correlation ID: 158ce820-b947-4aaa-b3f3-c0276a87a583
  • LLM: anthropic--claude-4.6-sonnet
  • File Content Strategy: Full file content
  • Summary Prompt: Default Prompt

@Schmarvinius Schmarvinius requested a review from a team as a code owner April 14, 2026 15:18
Copy link
Copy Markdown
Contributor

@hyperspace-insights hyperspace-insights bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is a clean structural rename — renaming integration-tests/srv to integration-tests/generic and introducing integration-tests/mtx-local/srv — with all references consistently updated across the pipeline workflow, Piper config, and .cdsrc.json. However, the regression test NonAttachmentCompositionDraftTest (guarding against the cap/issues#20410 bug) was deleted without being migrated to the new integration-tests/generic module, leaving a coverage gap. The test should be recreated under integration-tests/generic/src/test/java/com/sap/cds/feature/attachments/integrationtests/draftservice/.

PR Bot Information

Version: 1.20.11 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback

  • Event Trigger: pull_request.opened
  • Agent Instructions:
  • Correlation ID: 158ce820-b947-4aaa-b3f3-c0276a87a583
  • LLM: anthropic--claude-4.6-sonnet
  • File Content Strategy: Full file content

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant