Open
Conversation
Contributor
There was a problem hiding this comment.
The PR is a clean structural rename — renaming integration-tests/srv to integration-tests/generic and introducing integration-tests/mtx-local/srv — with all references consistently updated across the pipeline workflow, Piper config, and .cdsrc.json. However, the regression test NonAttachmentCompositionDraftTest (guarding against the cap/issues#20410 bug) was deleted without being migrated to the new integration-tests/generic module, leaving a coverage gap. The test should be recreated under integration-tests/generic/src/test/java/com/sap/cds/feature/attachments/integrationtests/draftservice/.
PR Bot Information
Version: 1.20.11 | 📖 Documentation | 🚨 Create Incident | 💬 Feedback
- Event Trigger:
pull_request.opened - Agent Instructions:
- Correlation ID:
158ce820-b947-4aaa-b3f3-c0276a87a583 - LLM:
anthropic--claude-4.6-sonnet - File Content Strategy: Full file content
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce
.cdsrcConfiguration and Clean Up RemnantsRefactor
♻️ Cleaned up leftover configuration and references related to the previous integration test structure, updating module exclusions and removing obsolete settings.
Changes
.github/workflows/pipeline.yml: Updated the Maven deploy command to exclude the renamed/restructured integration test modules (integration-tests/genericandintegration-tests/mtx-local/srv) instead of the oldintegration-tests/srv..pipeline/config.yml: Updated Synopsys Detect (Black Duck) scan exclusions to reflect the new integration test module paths (integration-tests/generic,integration-tests/mtx-local/srv), replacing the oldintegration-tests/srvreference.integration-tests/.cdsrc.json: Removed stalerequires(persistent-outbox) andfiori(draft_messages) configuration entries, leaving only thebuildtask definition.integration-tests/srv/src/test/java/.../NonAttachmentCompositionDraftTest.java: Removed this test file as part of the integration test structure cleanup.📬 Subscribe to the Hyperspace PR Bot DL to get the latest announcements and pilot features!
PR Bot Information
Version:
1.20.11| 📖 Documentation | 🚨 Create Incident | 💬 Feedbackpull_request.opened158ce820-b947-4aaa-b3f3-c0276a87a583anthropic--claude-4.6-sonnet