Skip to content

[review] Security Guide#2321

Merged
renejeglinsky merged 24 commits intomainfrom
rjegl01/secReview
Feb 3, 2026
Merged

[review] Security Guide#2321
renejeglinsky merged 24 commits intomainfrom
rjegl01/secReview

Conversation

@renejeglinsky
Copy link
Contributor

@renejeglinsky renejeglinsky commented Jan 16, 2026

General remarks on:

@renejeglinsky
Copy link
Contributor Author

Remote Authentication

That guide is based on a Java sample only, right? Are there plans for Node.js as well?


> <sup>1</sup>For bound actions and functions that are not bound against a collection, Node.js supports instance-based authorization at the entity level. For example, you can use `where` clauses that *contain references to the model*, such as `where: CreatedBy = $user`. For all bound actions and functions, Node.js supports simple static expressions at the entity level that *don't have any reference to the model*, such as `where: $user.level = 2`.
> <sup>1</sup>For bound actions and functions that are not bound against a collection, Node.js supports instance-based authorization at the entity level, see [link] (somewhere in Node.js docs)<br>
> <sup>2</sup> For unbound actions and functions, Node.js supports simple static expressions that *don't have any reference to the model*, such as `where: $user.level = 2`.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it say "bound and unbound actions and functions"? In consequence we should add <sup>2</sup> also in the table for entity.
See:

Image
Suggested change
> <sup>2</sup> For unbound actions and functions, Node.js supports simple static expressions that *don't have any reference to the model*, such as `where: $user.level = 2`.
> <sup>2</sup> For bound and unbound actions and functions, Node.js supports simple static expressions that *don't have any reference to the model*, such as `where: $user.level = 2`.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BraunMatthias What do you think?

@renejeglinsky renejeglinsky marked this pull request as ready for review January 20, 2026 15:00
Comment on lines 1327 to 1329
::: warning
If you switch off CAP authentication, make sure that the internal communication channels are secured by the given infrastructure.
:::
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@BraunMatthias How about moving this note into the java div with the hint how to turn off authentication? If there's is no equivalent in Node.js then we could move it into the Java div as it doesn't apply to Node.js at all. Right?

@renejeglinsky
Copy link
Contributor Author

Remote Authentication

That guide is based on a Java sample only, right? Are there plans for Node.js as well?

@sjvans How would you see that? Is there something to fill from the Node.js perspective?

@sjvans
Copy link
Contributor

sjvans commented Feb 2, 2026

Remote Authentication

That guide is based on a Java sample only, right? Are there plans for Node.js as well?

@sjvans How would you see that? Is there something to fill from the Node.js perspective?

@renejeglinsky the same concepts apply, but configs (e.g., application.yaml vs package.json) differ. we could create a node version/ input for one if you'd like

Co-authored-by: Paul <paul.erlenwein@gmail.com>
Removed unsupported privilege properties example from authorization documentation.
@renejeglinsky
Copy link
Contributor Author

Remote Authentication

That guide is based on a Java sample only, right? Are there plans for Node.js as well?

@sjvans How would you see that? Is there something to fill from the Node.js perspective?

@renejeglinsky the same concepts apply, but configs (e.g., application.yaml vs package.json) differ. we could create a node version/ input for one if you'd like

Please do so in a new PR. I think it would add value. Matthias was not so sure, that's why I asked you.

@renejeglinsky renejeglinsky merged commit d7d87bb into main Feb 3, 2026
7 of 8 checks passed
@renejeglinsky renejeglinsky deleted the rjegl01/secReview branch February 3, 2026 19:23
@sjvans
Copy link
Contributor

sjvans commented Feb 4, 2026

Remote Authentication

That guide is based on a Java sample only, right? Are there plans for Node.js as well?

@sjvans How would you see that? Is there something to fill from the Node.js perspective?

@renejeglinsky the same concepts apply, but configs (e.g., application.yaml vs package.json) differ. we could create a node version/ input for one if you'd like

Please do so in a new PR. I think it would add value. Matthias was not so sure, that's why I asked you.

added to our backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants