Review databases "compiled to" from CAP Java#2329
Open
Conversation
agoerler
commented
Jan 20, 2026
patricebender
approved these changes
Jan 23, 2026
agoerler
commented
Jan 23, 2026
Co-authored-by: Patrice Bender <patrice.bender@sap.com>
Contributor
There was a problem hiding this comment.
Spelling Mistakes
- guides/databases/cdl-to-ddl.md:196:22 Unknown word "slugified"
- guides/databases/cdl-to-ddl.md:197:23 Unknown word "slugification"
- guides/databases/cdl-to-ddl.md:197:120 Unknown word "slugified"
- guides/databases/cdl-to-ddl.md:204:24 Unknown word "slugified"
- guides/databases/cdl-to-ddl.md:205:70 Unknown word "slugified"
Generally, for each spelling mistake there are 2 ways to fix it:
- Fix the spelling mistake and commit it.
- The word is incorrectly reported as misspelled → put the word on the project-words.txt list, located in the root project directory.
|
|
||
| > [!tip] Guaranteed & Stable Slugification | ||
| > The slugification effects are guaranteed and stable, which means that you can rely on it and use the slugified names in native SQL queries. For example, both of the following CQL queries are equivalent and will work as expected: | ||
| > [!tip] You may use slugified names in CAP Node.js |
Contributor
There was a problem hiding this comment.
Suggested change
| > [!tip] You may use slugified names in CAP Node.js | |
| > [!tip] You may use studified names in CAP Node.js |
Or maybe one of these: slugged, slugify, sluiced, slugabed?
| > [!tip] Guaranteed & Stable Slugification | ||
| > The slugification effects are guaranteed and stable, which means that you can rely on it and use the slugified names in native SQL queries. For example, both of the following CQL queries are equivalent and will work as expected: | ||
| > [!tip] You may use slugified names in CAP Node.js | ||
| > In CAP Node.js, the slugification effects are guaranteed and stable, which means that you can rely on it and use the slugified names in _native SQL_ queries. For example, both of the following CQL queries are equivalent and will work as expected: |
Contributor
There was a problem hiding this comment.
Suggested change
| > In CAP Node.js, the slugification effects are guaranteed and stable, which means that you can rely on it and use the slugified names in _native SQL_ queries. For example, both of the following CQL queries are equivalent and will work as expected: | |
| > In CAP Node.js, the specification effects are guaranteed and stable, which means that you can rely on it and use the slugified names in _native SQL_ queries. For example, both of the following CQL queries are equivalent and will work as expected: |
Or maybe one of these: ?
| > [!tip] Guaranteed & Stable Slugification | ||
| > The slugification effects are guaranteed and stable, which means that you can rely on it and use the slugified names in native SQL queries. For example, both of the following CQL queries are equivalent and will work as expected: | ||
| > [!tip] You may use slugified names in CAP Node.js | ||
| > In CAP Node.js, the slugification effects are guaranteed and stable, which means that you can rely on it and use the slugified names in _native SQL_ queries. For example, both of the following CQL queries are equivalent and will work as expected: |
Contributor
There was a problem hiding this comment.
Suggested change
| > In CAP Node.js, the slugification effects are guaranteed and stable, which means that you can rely on it and use the slugified names in _native SQL_ queries. For example, both of the following CQL queries are equivalent and will work as expected: | |
| > In CAP Node.js, the slugification effects are guaranteed and stable, which means that you can rely on it and use the studified names in _native SQL_ queries. For example, both of the following CQL queries are equivalent and will work as expected: |
Or maybe one of these: slugged, slugify, sluiced, slugabed?
| await cds.run `SELECT from sap.capire.bookshop.Books` | ||
| await cds.run `SELECT from sap_capire_bookshop_Books` | ||
| ``` | ||
| > [!warning] Don't use slugified names in CAP Java |
Contributor
There was a problem hiding this comment.
Suggested change
| > [!warning] Don't use slugified names in CAP Java | |
| > [!warning] Don't use studified names in CAP Java |
Or maybe one of these: slugged, slugify, sluiced, slugabed?
| await cds.run `SELECT from sap_capire_bookshop_Books` | ||
| ``` | ||
| > [!warning] Don't use slugified names in CAP Java | ||
| In CAP Java, you can use fully qualified entity names with dots. The slugified names can't be used in CQL queries. |
Contributor
There was a problem hiding this comment.
Suggested change
| In CAP Java, you can use fully qualified entity names with dots. The slugified names can't be used in CQL queries. | |
| In CAP Java, you can use fully qualified entity names with dots. The studified names can't be used in CQL queries. |
Or maybe one of these: slugged, slugify, sluiced, slugabed?
MattSchur
reviewed
Jan 29, 2026
MattSchur
reviewed
Jan 29, 2026
MattSchur
approved these changes
Jan 29, 2026
Co-authored-by: Matthias Schur <107557548+MattSchur@users.noreply.github.com>
Contributor
|
Please resolve the conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.