Change host mode default response to HTML #3936
Merged
+289
−113
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stances For published realms with generic Accept headers (like */*), distinguish card URLs from module URLs. Module imports (e.g., "./person") resolve to URLs without extensions and would incorrectly get HTML served instead of module content, causing FilterRefersToNonexistentTypeError. Now only serve HTML if: 1. This is a directory index request (path ends with /), OR 2. The URL corresponds to an indexed card instance Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
backspace
added
enhancement
backspace
added
bug
Contributor
Author
|
I didn’t mean to request review on this yet! |
These were passing locally but not in CI.
lukemelia
approved these changes
Feb 4, 2026
Contributor
lukemelia
left a comment
lukemelia
left a comment
There was a problem hiding this comment.
This will likely get more complicated when we build routing, but this seems good for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make embeds work on more platforms, which don’t specify the
Accept: text/htmlheader we were expecting to serve host mode responses.(#3947 has
server.tsextractions related to this work.)When I deployed this to production, Whatsapp:
OpenGraph:
OrcaScan validator warns of missing tags, which has its own issue (10140) but mostly works: