Add rewards handling chainspec setting#5387
Open
darthsiroftardis wants to merge 8 commits intocasper-network:devfrom
Open
Add rewards handling chainspec setting#5387darthsiroftardis wants to merge 8 commits intocasper-network:devfrom
darthsiroftardis wants to merge 8 commits intocasper-network:devfrom
Conversation
Contributor
|
Could you please describe what this PR do (it doesn't just add a flag to chainspec)? I think, I've understood it, but it would be useful to see what was your intent. Also, the code is not commented at all, which makes it really hard to understand. Could you please comment all public functions and add short descriptions to the test scenarios? (given/when/then format would be great). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CHANGELOG:
rewards_handlingmode to the chainspec