Skip to content

Add rewards handling chainspec setting#5387

Open
darthsiroftardis wants to merge 8 commits intocasper-network:devfrom
darthsiroftardis:auction-reward-split
Open

Add rewards handling chainspec setting#5387
darthsiroftardis wants to merge 8 commits intocasper-network:devfrom
darthsiroftardis:auction-reward-split

Conversation

@darthsiroftardis
Copy link
Contributor

CHANGELOG:

  • Adds a new rewards_handling mode to the chainspec

@zie1ony
Copy link
Contributor

zie1ony commented Feb 27, 2026

Could you please describe what this PR do (it doesn't just add a flag to chainspec)? I think, I've understood it, but it would be useful to see what was your intent.

Also, the code is not commented at all, which makes it really hard to understand. Could you please comment all public functions and add short descriptions to the test scenarios? (given/when/then format would be great).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants