* Added chainspec property minimum_delegation_rate#5389
Merged
zajko merged 2 commits intocasper-network:devfrom Mar 4, 2026
Merged
* Added chainspec property minimum_delegation_rate#5389zajko merged 2 commits intocasper-network:devfrom
zajko merged 2 commits intocasper-network:devfrom
Conversation
zajko
force-pushed
the
minimum_delegation_rate_limit
branch
9 times, most recently
from
85b0abc to
93e3361
Compare
darthsiroftardis
approved these changes
Mar 3, 2026
Contributor
darthsiroftardis
left a comment
darthsiroftardis
left a comment
There was a problem hiding this comment.
optimistic approval pending CI
zajko
force-pushed
the
minimum_delegation_rate_limit
branch
8 times, most recently
from
11d22cd to
fcc962a
Compare
zajko
force-pushed
the
minimum_delegation_rate_limit
branch
2 times, most recently
from
15d61f5 to
c7c462f
Compare
Minimum delegation rate applies to new add bids and new reservations Co-author: Michał Papierski michal@papierski.net
zajko
force-pushed
the
minimum_delegation_rate_limit
branch
from
c7c462f to
7ccfb2e
Compare
Comment on lines
+259
to
+273
| let minimum_delegation_rate_uref = self | ||
| .address_generator | ||
| .borrow_mut() | ||
| .new_uref(AccessRights::READ_ADD_WRITE); | ||
| let cl_value = CLValue::from_t(minimum_delegation_rate) | ||
| .map_err(|cl_error| GenesisError::CLValue(cl_error.to_string()))?; | ||
| self.tracking_copy.borrow_mut().write( | ||
| minimum_delegation_rate_uref.into(), | ||
| StoredValue::CLValue(cl_value), | ||
| ); | ||
| named_keys.insert( | ||
| MINIMUM_DELEGATION_RATE_KEY.into(), | ||
| minimum_delegation_rate_uref.into(), | ||
| ); | ||
|
|
Collaborator
There was a problem hiding this comment.
is there a good reason this isn't being done later in this flow, when the other auction named keys are seeded?
Contributor
Author
There was a problem hiding this comment.
Not really. I'll move it in a separate PR.
EdHastingsCasperAssociation
approved these changes
Mar 4, 2026
Collaborator
EdHastingsCasperAssociation
left a comment
EdHastingsCasperAssociation
left a comment
There was a problem hiding this comment.
lgtm, one cohesion nit pick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-author: Michał Papierski michal@papierski.net