Merged
Conversation
🧪 Review environmenthttps://kxcgmv4z7opacax3usdcjxwmqq0ychfq.lambda-url.ca-central-1.on.aws/ |
andrewleith
reviewed
Apr 14, 2026
Member
andrewleith
left a comment
There was a problem hiding this comment.
A couple of comments below.
…ort, function or class' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
This pull request refactors the rich text editor's toolbar and tooltips to enhance accessibility. It centralizes all editor UI labels and keyboard shortcuts (with platform-specific variants) into a new localization module, replaces ad-hoc label definitions with context-based translation, and updates the Cypress tests to accommodate these changes. Additionally, it improves tooltip accessibility and updates the test suite to check for both English and French UI labels.
Test instructions | Instructions pour tester la modification
aria-pressed: Confirmaria-pressedisfalse→true→falsewhen applying/removing formatting for every button.Alt+F10to focus the toolbar; assert initial focus (H1) and that arrow keys move focus forwards/backwards and restore remembered position.Mod+Alt+1for Heading,Mod+bfor Bold), verify the corresponding button toggles aria-pressed.Mod+Kto open the link modal; verify it is visible and that Escape closes it.