Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a new GitHub Actions workflow to automatically build and push Docker images to the development ECR repository when changes are pushed to the dev branch. Additionally, it simplifies the staging lambda workflow by removing New Relic conditional logic.
Key changes:
- New automated workflow for building both lambda and k8s images on dev branch pushes
- Simplified staging lambda workflow by removing New Relic-specific Dockerfile selection logic
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/dev_branch_build_push_images.yaml |
New workflow that builds and pushes api-lambda-dev and api-dev images to dev ECR on pushes to dev branch |
.github/workflows/lambda_staging.yml |
Removed New Relic environment variable detection and conditional Dockerfile selection logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
8 tasks
…using the new roles in TF
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary | Résumé
new workflow to handle building and deploying images to our dev ECR on dev branch changes
Related Issues | Cartes liées
https://app.zenhub.com/workspaces/notify-planning-core-6411dfb7c95fb80014e0cab0/issues/gh/cds-snc/notification-planning-core/741
Reviewer checklist | Liste de vérification du réviseur