[cephfs] add subvolumegroup info

[lcaflc]

Add SubVolumeGroupInfo into the cephfs/admin api.

This is mainly usefull for subvolumegroup size and quota informations.

[phlogistonjohn]

Thanks for the contribution. Please update the commit messages to use the same style previous commits in this project use for that package (see also the ceph/ceph docs https://github.com/ceph/ceph/blob/main/SubmittingPatches.rst#commit-title which we share).

[lcaflc]

Hi, Sorry for the commit messages I'm so used that I forgot it after reading the development documentation of the project.

I'm not also fully sure about docs/api-status.json and setting the new API as preview. It was not completely clear in my mind, if it must be done for new API for next / dev versions of ceph upstream, and so not applicable to current ceph releases and tests, or for new apis in the project. I've updated it by hand as adding //go:build ceph_preview into the file set the complete subvolumegroup.go apis as preview.

And congrats for the builtin tests that spawn a tiny cluster, this is really awesome.

[phlogistonjohn]

Hi, Sorry for the commit messages I'm so used that I forgot it after reading the development documentation of the project.

Thanks for updating.

I'm not also fully sure about docs/api-status.json and setting the new API as preview. It was not completely clear in my mind, if it must be done for new API for next / dev versions of ceph upstream, and so not applicable to current ceph releases and tests, or for new apis in the project. I've updated it by hand as adding //go:build ceph_preview into the file set the complete subvolumegroup.go apis as preview.

Let me try and explain - the ideal is that when a new function or type is added it should be added to a new file. The new file then contains the preview build tag. This goes for new tests as well, create a new file. Go has no restriction on adding "methods" to a type defined in a different file.

When I enable the CI workflows there's a good chance it will flag the new apis as not first going through preview. Regardless, even if the CI doesn't detect it we'll want to move the new code to new files properly tagged.

And congrats for the builtin tests that spawn a tiny cluster, this is really awesome.

It is nice. I credit the previous maintainers of the project for setting that up.

[lcaflc]

Thanks @phlogistonjohn,

I've update the PR to reflect your explanations. new API is now moved to admin/cephfs/subvolumegroup_info.go.

I've added the //go:build ceph_preview tag to the file and rebuilt the api documentation.

Thanks.

[phlogistonjohn]

@Mergifyio rebase

[mergify]

rebase

❌ Pull request can't be updated with latest base branch changes

Details

Mergify needs the author permission to update the base branch of the pull request.
@lcaflc needs to authorize modification on its head branch.

[phlogistonjohn]

Hi @lcaflc can you please rebase this PR? Or grant authorizaion for others to do so? The mergify bot is unable to work it's magic.

[lcaflc]

@phlogistonjohn Should be ok now. Thanks.

[anoopcs9]

We also have casesensitive and normalization fields in addition to the above from tentacle. But I guess those can wait a little more.

[phlogistonjohn]

Cool. Yeah, I don't think it's needed to do everything in one PR.