Skip to content

Remove unnecessary null pointer checks before delete/free #56

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lumir-sliva wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove unnecessary null pointer checks before delete/free #56

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions auth_plugin/ProtoUtils.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,13 +255,8 @@ utils::GetXrdSfsPrep(const eos::auth::XrdSfsPrepProto& proto_obj)
//------------------------------------------------------------------------------
void utils::DeleteXrdSfsPrep(XrdSfsPrep*& obj)
{
if (obj->reqid) {
free(obj->reqid);
}

if (obj->notify != nullptr) {
free(obj->notify);
}
free(obj->reqid);
free(obj->notify);

XrdOucTList* currentPath = obj->paths;

Expand Down
6 changes: 2 additions & 4 deletions fst/http/s3/S3Handler.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,10 +132,8 @@ S3Handler::HandleRequest(eos::common::HttpRequest* request)

if (!mHttpResponse || request->GetBodySize() == 0) {
// clean-up left-over objects on error or end-of-put
if (mFile) {
delete mFile;
mFile = 0;
}
delete mFile;
mFile = 0;
}
}
}
Expand Down
9 changes: 2 additions & 7 deletions fst/xrdcl_plugins/RainFile.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,13 +52,8 @@ RainFile::~RainFile()
{
eos_debug("calling destructor");

if (pFile) {
delete pFile;
}

if (pRainFile) {
delete pRainFile;
}
delete pFile;
delete pRainFile;
}


Expand Down