Open
Conversation
jessegeens
force-pushed
the
feat/lw-acls-email
branch
10 times, most recently
from
874910a to
60e8894
Compare
jessegeens
force-pushed
the
feat/lw-acls-email
branch
from
60e8894 to
5189142
Compare
glpatcern
reviewed
Apr 9, 2026
Member
glpatcern
left a comment
glpatcern
left a comment
There was a problem hiding this comment.
Some comments, knowing this is not to be merged immediately
|
|
||
| func (m *manager) fetchExternalIdentities(ctx context.Context, email string) ([]*userpb.ExternalIdentity, error) { | ||
| log := appctx.GetLogger(ctx) | ||
| url := fmt.Sprintf("%s/api/v1.0/Identity/by_email/%s?filter=blocked%%3Afalse&filter=disabled%%3Afalse&field=upn&field=primaryAccountEmail&field=displayName&field=uid&field=gid&field=type&field=source&field=activeUser", m.conf.APIBaseURL, email) |
Member
There was a problem hiding this comment.
can we do this or we have to populate all fields of Identity?
Suggested change
| url := fmt.Sprintf("%s/api/v1.0/Identity/by_email/%s?filter=blocked%%3Afalse&filter=disabled%%3Afalse&field=upn&field=primaryAccountEmail&field=displayName&field=uid&field=gid&field=type&field=source&field=activeUser", m.conf.APIBaseURL, email) | |
| url := fmt.Sprintf("%s/api/v1.0/Identity/by_email/%s?filter=blocked%%3Afalse&filter=disabled%%3Afalse&field=upn&field=source", m.conf.APIBaseURL, email) |
| if i.UserType() == userpb.UserType_USER_TYPE_LIGHTWEIGHT && i.PrimaryAccountEmail != "" { | ||
| u.Id.OpaqueId = i.PrimaryAccountEmail | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
What do we do now if user type == LIGHTWEIGHT and email == "" ? I fear we can't infer this is a linked account, which we have agreed to not support, but anyhow we probably want to fail.
diocas
approved these changes
Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.