Skip to content

upmap: add regex to remove inf from osd dump before parsing to JSON#47

Open
JoshuaGabriel wants to merge 1 commit intocernceph:masterfrom
JoshuaGabriel:josh_upmap
Open

upmap: add regex to remove inf from osd dump before parsing to JSON#47
JoshuaGabriel wants to merge 1 commit intocernceph:masterfrom
JoshuaGabriel:josh_upmap

Conversation

@JoshuaGabriel
Copy link
Contributor

read balancer throwing 'inf' in osd dump, this line parses all inf into the string form

#46

Signed-off-by: Joshua Blanch <joshua.blanch@clyso.com>
@Avatat
Copy link

Avatat commented Jun 17, 2025

I can confirm that the issue appeared on clusters that were freshly updated from Pacific to Reef.

However, I fixed it in a slightly different, easier way:

osd_dump_json = output.decode('utf-8').strip().replace(":inf", ":Infinity")

Still, Infinity is not a valid JSON property, but it is accepted by Python's json lib and jq for example. Maybe we should change it in the Ceph/rados library?

@JoshuaGabriel
Copy link
Contributor Author

@Avatat I think this fix is on its way, already in 18.2.5 https://tracker.ceph.com/issues/66215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants