refactor: rename Manager classes and consolidate color handling#732
Merged
lcottercertinia merged 5 commits intocertinia:mainfrom Feb 25, 2026
Merged
refactor: rename Manager classes and consolidate color handling#732lcottercertinia merged 5 commits intocertinia:mainfrom
lcottercertinia merged 5 commits intocertinia:mainfrom
Conversation
… names - RectangleManager with RectangleCache and update related components - Updated SearchOrchestrator to use EventMatcher instead of SearchManager for search functionality. - Refactored SelectionOrchestrator to utilize SelectionNavigator instead of SelectionManager for selection operations. - Introduced EventMatcher class for generic event searching, decoupling from LogEvent-specific implementation. - Updated various renderer components to reference PrecomputedRect from RectangleCache instead of RectangleManager. - Enhanced tooltip utility documentation to reflect changes in tooltip rendering. - Adjusted tree conversion logic to align with RectangleCache optimizations.
- Introduced EditorColors interface to encapsulate resolved color values for PixiJS renderers. - Updated TimelineFlameChart to extract editor colors from CSS custom properties. - Modified TimelineView to define new CSS variables for editor theming. - Enhanced FlameChart, MeasureRangeRenderer, MinimapRenderer, and others to accept and utilize resolved color values. - Refactored rendering logic in SearchHighlightRenderer and SelectionHighlightRenderer to use provided highlight colors. - Updated tooltip styles to reference new CSS variables for consistent theming. - Removed direct CSS variable extraction in favor of pre-resolved color values for performance improvements.
lcottercertinia
previously approved these changes
Feb 25, 2026
lcottercertinia
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 PR Overview
Renames vague "Manager" classes throughout the timeline to use intent-revealing names, and consolidates duplicated color logic into shared utilities while decoupling timeline CSS colors from VS Code theme tokens.
🛠️ Changes made
SelectionManager→SelectionNavigator,RectangleManager→RectangleCache,HitTestManager→HitDetector,MeasurementManager→MeasurementState,MinimapManager→MinimapViewport,SearchManager→EventMatcher,TimelineTooltipManager→FrameTooltipRenderer,MetricStripManager→MetricTierClassifierColorUtils🧩 Type of change (check all applicable)
🔗 Related Issues
None
✅ Tests added?
📚 Docs updated?
Anything else we need to know?
56 files changed with a net reduction of ~95 lines. All existing tests updated to reference new class names.