Skip to content

fix: handle 404 correctly #2700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
migmartri merged 3 commits into from
Feb 3, 2026
+6 −10
Merged

fix: handle 404 correctly #2700

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e5469b
fix: handle 404 correctly
migmartri Feb 2, 2026
72f2600
fix: handle 404 correctly
migmartri Feb 2, 2026
2a4bb97
fix: handle 404 correctly
migmartri Feb 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/controlplane/pkg/biz/casmapping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2023-2025 The Chainloop Authors.
// Copyright 2023-2026 The Chainloop Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down
14 changes: 5 additions & 9 deletions app/controlplane/pkg/data/casmapping.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
//
// Copyright 2024-2025 The Chainloop Authors.
// Copyright 2024-2026 The Chainloop Authors.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -82,8 +82,8 @@ func (r *CASMappingRepo) FindByDigest(ctx context.Context, digest string) ([]*bi
for _, m := range mappings {
public, err := r.IsPublic(ctx, r.data.DB, m.WorkflowRunID)
if err != nil {
if biz.IsNotFound(err) {
return nil, nil
if ent.IsNotFound(err) {
continue
}

return nil, fmt.Errorf("failed to check if workflow is public: %w", err)
Expand Down Expand Up @@ -112,8 +112,8 @@ func (r *CASMappingRepo) findByID(ctx context.Context, id uuid.UUID) (*biz.CASMa

public, err := r.IsPublic(ctx, r.data.DB, backend.WorkflowRunID)
if err != nil {
if biz.IsNotFound(err) {
return nil, nil
if ent.IsNotFound(err) {
return nil, biz.NewErrNotFound("cas mapping")
}

return nil, fmt.Errorf("failed to check if workflow is public: %w", err)
Expand All @@ -132,15 +132,11 @@ func (r *CASMappingRepo) IsPublic(ctx context.Context, client *ent.Client, runID
wr, err := client.WorkflowRun.Query().Where(workflowrun.ID(runID)).Select(workflowrun.FieldWorkflowID).First(ctx)
if err != nil {
return false, fmt.Errorf("failed to get workflow run: %w", err)
} else if wr == nil {
return false, nil
}

workflow, err := client.Workflow.Query().Where(workflow.ID(wr.WorkflowID)).Select(workflow.FieldPublic).First(ctx)
if err != nil {
return false, fmt.Errorf("failed to get workflow: %w", err)
} else if workflow == nil {
return false, nil
}

return workflow.Public, nil
Expand Down
Loading