Conversation
|
I'm confused by some of the test fails - does a clean PR fail at the moment (due to a system update?) or has this PR got some unintended side effect? |
|
That seems to be the case, I haven't looked into why MacOS failed yet, and style failed because I touched PAL. |
|
With these changes (there are a couple of things needing better checks or further investigation) my build hits a wall with system libicu, which is a lot newer than Linux system version or the one we embed. |
f01359b to
f043e67
Compare
Use 'gmake' instead of 'make' on FreeBSD, confirm it is available in CMake.
Reuse existing implementation, but change the include from sysctl.h to resource.h - that should still work on other POSIX platforms.
Find symbols for GNU gettext and sysinfo. Requires `gettext` and `libsysinfo` packages (ports) to be installed.
|
Unfortunately, there are still PAL runtime errors on FreeBSD, maybe still too early. |
|
The idea with CC's PAL integration was to try to only include the parts of PAL we actually need (several components are deliberately omitted) whilst we do have some excess bits I wonder if the issue here is that we are missing code that's needed for FreeBSD |
Initial FreeBSD support with
EMBED_ICU, which disables native tests. ICU version in FreeBSD package tree is too new - something to sort out next.To do