Skip to content

api(@deltachat-stdio-rpc-server): also export a class#7628

Merged
link2xt merged 3 commits intochatmail:mainfrom
davidsm10:npm-package-export-class
Apr 9, 2026
Merged

api(@deltachat-stdio-rpc-server): also export a class#7628
link2xt merged 3 commits intochatmail:mainfrom
davidsm10:npm-package-export-class

Conversation

@davidsm10
Copy link
Copy Markdown

This is convenient for bots and libs for bots, so they can extend from this class directly.

@Simon-Laux Simon-Laux self-requested a review December 19, 2025 18:06
Comment thread deltachat-rpc-server/npm-package/index.js
This is convenient for bots and libs for bots, so they can extend from this class directly
@davidsm10 davidsm10 force-pushed the npm-package-export-class branch from 3d0fa2b to 0136a97 Compare December 19, 2025 18:26
Copy link
Copy Markdown
Member

@Simon-Laux Simon-Laux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@davidsm10 davidsm10 force-pushed the npm-package-export-class branch from 7f3ab54 to d288557 Compare December 19, 2025 19:06
@davidsm10 davidsm10 marked this pull request as ready for review December 22, 2025 23:28
@davidsm10 davidsm10 force-pushed the npm-package-export-class branch from d288557 to 834a3c3 Compare December 22, 2025 23:31
@Simon-Laux
Copy link
Copy Markdown
Member

Simon-Laux commented Jan 15, 2026

CAN NOT RUN COVERAGE correctly: Missing CHATMAIL_DOMAIN environment variable!

A bit annoying that CI tests only work for members of the chat mail organization.

@davidsm10
Copy link
Copy Markdown
Author

Hey, any update on this? Anything I can do to get it merged?

@link2xt link2xt merged commit e3bf6bf into chatmail:main Apr 9, 2026
23 of 31 checks passed
@link2xt
Copy link
Copy Markdown
Collaborator

link2xt commented Apr 9, 2026

I merged it, CI passes on main so this will get into the next release (2.49.0)

@davidsm10 davidsm10 deleted the npm-package-export-class branch April 10, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants