Open
Conversation
Add two utilities `unsafeConnect{Aligned,Flipped}` to the `domain` package
that help when a user needs to d an unsafe bidirectional crossing. This
comes up for almost any non-trivial bundle (e.g., any `Decoupled`).
This fills a hole in the current APIs where `domain.unsafeCast` produces a
node-like value that, if the only API provided, would force users to blow
out the bundle into its constituent fields.
Note: this would be better handled with tighter integration with
`Connectable` via operations which allow you to get views of the aligned
or flipped leaf fields.
AI-assisted-by: Claude Code (Claude Sonnet 4.6)
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add two utilities
unsafeConnect{Aligned,Flipped}to thedomainpackagethat help when a user needs to d an unsafe bidirectional crossing. This
comes up for almost any non-trivial bundle (e.g., any
Decoupled).This fills a hole in the current APIs where
domain.unsafeCastproduces anode-like value that, if the only API provided, would force users to blow
out the bundle into its constituent fields.
Note: this would be better handled with tighter integration with
Connectablevia operations which allow you to get views of the alignedor flipped leaf fields.
AI-assisted-by: Claude Code (Claude Sonnet 4.6)
Release Notes
Add
domain.unsafeConnect{Aligned,Flipped}to allow for a combined domain castand connect of aligned or flipped fields. This fills a hole in the existing
domain.unsafeCastAPI in that this produces a read-only "node-like" valuewhich makes doing bidirectional crossings tedious.