Add dmdrvi v0.5 eof API support with file-size fallback#39
Merged
JohnAmadis merged 2 commits intomainfrom Mar 11, 2026
Merged
Conversation
- Add bytes_read field to file_handle_t to track total bytes read - Initialize bytes_read = 0 on file open (_fopen) - Accumulate bytes_read after each _fread call - Modify _eof to delegate to driver's eof API if implemented, otherwise fall back to comparing bytes_read against file size, and return 0 (not at EOF) if file size is unavailable Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add support for new eof API in dmdevfs
Add dmdrvi v0.5 Mar 11, 2026
eof API support with file-size fallback
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_eofin dmdevfs always returned 0 (never at EOF), which required every driver to implement its own EOF tracking. With dmdrvi v0.5 introducing an optionaleofAPI, dmdevfs should delegate to it when available and fall back to size-based calculation otherwise.Changes
file_handle_t— addedbytes_readfield to accumulate total bytes read per handle_fopen— initializesbytes_read = 0_fread— incrementshandle->bytes_readafter each read_eof— new priority logic:dmod_dmdrvi_eof_sig→ delegate to it (streaming drivers can returnfalsepermanently)driver_statreturns a size →bytes_read >= size0(indeterminate)Default behavior flips from "never EOF" to "file-like EOF" — drivers that need streaming semantics must now opt in via the
eofAPI.Original prompt
🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.