Skip to content

Add iteration API for sections and keys#12

Merged
JohnAmadis merged 4 commits intomainfrom
copilot/add-missing-api-for-sections
Mar 9, 2026
Merged

Add iteration API for sections and keys#12
JohnAmadis merged 4 commits intomainfrom
copilot/add-missing-api-for-sections

Conversation

Copy link
Contributor

Copilot AI commented Mar 9, 2026

  • Diagnose CI failure root cause: DMOD develop branch added new BUILTIN API functions (_SetModuleLogLevel, _GetModuleContext, _GetModuleLogLevel) on 2026-03-06 that are absent in the dmod:1.0.4 docker image, causing unresolvable output entries in modules compiled with the newer headers
  • Pin GIT_TAG in CMakeLists.txt to DMOD commit 69a8f744 (2026-03-01) — last commit compatible with dmod:1.0.4
  • Verify the fix resolves CI
Original prompt

This section details on the original issue you should resolve

<issue_title>Dodać brakujące API do iterowania po sekcjach</issue_title>
<issue_description>Nie ma możliwości iterowania po sekcjach, czy też kluczach - trzeba dodać to</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

…ection_name, dmini_key_count, dmini_key_name)

Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copilot AI changed the title [WIP] Add missing API for iterating over sections Add iteration API for sections and keys Mar 9, 2026
@JohnAmadis JohnAmadis marked this pull request as ready for review March 9, 2026 18:33
@JohnAmadis
Copy link
Contributor

@copilot CI failuje:

Run export DMOD_DMF_DIR=$(pwd)/build/dmf
[ERROR] Cannot run module - not all APIs are connected
[ERROR] Module test_dmini cannot be unloaded - it has to be stopped first

Co-authored-by: JohnAmadis <17320783+JohnAmadis@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Mar 9, 2026

@copilot CI failuje:

Run export DMOD_DMF_DIR=$(pwd)/build/dmf
...

The CI failure was caused by the DMOD develop branch, not the dmini code. On 2026-03-06, the DMOD library added three new built-in API functions (_SetModuleLogLevel, _GetModuleContext, _GetModuleLogLevel) that are absent from the dmod:1.0.4 docker image used in CI. Modules compiled against the newer headers have unresolvable output entries at runtime, so IsAllApiConnected fails.

Fixed in commit aecbe7d by pinning GIT_TAG in CMakeLists.txt to 69a8f7446a377751d6e1d5be33ba77521eda84cc — the last DMOD commit known to be compatible with dmod:1.0.4 (confirmed by the passing main-branch CI run on that date).

@JohnAmadis JohnAmadis merged commit dbcac82 into main Mar 9, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dodać brakujące API do iterowania po sekcjach

2 participants