Open
Conversation
This code will be needed in another file. Modulesync does not seem to have built-in support for adding utility methods, so just put them in a local file and require it where the methods are needed.
This file is supposed to provide access to the same parameters for all choria modules, but some modules are lacking one or more of these parameters. By managing its content with modulesync, we ensure we have consistent interface for all modules.
These checks are performed on the Puppet Forge to give quality scores to modules, and are failing for the choria repositories: * The `ensure` parameter must be the first one in resource declaration; * Non-interpolated strings should be single, not double-quoted. A bunch of other issues are reported by puppet-lint, but as of today they do not seem to be part of the module score calculation, so in order to minimize changes, this commit do not address them. While these changes are gratuitous, they will allow the scoring of the modules to increase, giving users a more positive view of the care taken to maintain them.
smortex
force-pushed
the
msync-manifests
branch
from
9f85dba to
f8eb84a
Compare
Contributor
|
hmm, missed this one, its good to go @smortex ? |
Member
Author
It is good to go. You can review the changes that it wants to makes in the modules by looking at the "noop run / Run msync --noop against all modules (pull_request)" test above, and expand the "Run msync --noop" section. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All puppet modules managed with this repo are supposed to share a similar
manifests/init.ppfile, but in reality these files have slight differences that ModuleSync allows to avoid.Also, the modules on the Puppet forge have quite a bad quality score partly due to some style issues (example), so this PR also improve this.