Skip to content

Remove signal restriction logic from SelectedObject shader pipeline#454

Merged
chrxh merged 3 commits intodevelopfrom
copilot/remove-signal-restriction-logic
Feb 18, 2026
Merged

Remove signal restriction logic from SelectedObject shader pipeline#454
chrxh merged 3 commits intodevelopfrom
copilot/remove-signal-restriction-logic

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 17, 2026

Strip hasSignalRestriction, startAngle, and endAngle from the SelectedObject rendering path — these were placeholder fields (hardcoded to 0) with unused angle-based fragment discard logic.

  • SelectedObjectVertexData: Reduced to float pos[2] only
  • Shaders (VS/GS/FS): Removed signal restriction attributes, pass-through varyings, and angle-range fragment logic; FS now renders a simple white ring
  • RenderPipeline.cpp: Removed vertex attribute bindings for locations 1–3
  • GeometryKernels.cu: Removed dead field assignments in cudaExtractSelectedObjectData for both cells and energy particles
// Before
struct SelectedObjectVertexData {
    float pos[2];
    int hasSignalRestriction;
    float startAngle;
    float endAngle;
};

// After
struct SelectedObjectVertexData {
    float pos[2];
};

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…ryKernels

- Remove hasSignalRestriction, startAngle, endAngle from SelectedObjectVertexData
- Simplify SelectedObjectVS, SelectedObjectGS, SelectedObjectFS shaders
- Remove vertex attribute setup for removed fields in RenderPipeline.cpp
- Remove signal restriction field assignments in cudaExtractSelectedObjectData

Co-authored-by: chrxh <73127001+chrxh@users.noreply.github.com>
Copilot AI changed the title [WIP] Remove signal restriction logic in SelectedObject shader Remove signal restriction logic from SelectedObject shader pipeline Feb 17, 2026
Copilot AI requested a review from chrxh February 17, 2026 20:52
@chrxh chrxh marked this pull request as ready for review February 18, 2026 06:42
@chrxh chrxh merged commit a97501a into develop Feb 18, 2026
2 checks passed
@chrxh chrxh deleted the copilot/remove-signal-restriction-logic branch February 18, 2026 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants