Merged
Conversation
Contributor
|
Looks like 7.0 is out: http://doc.pypy.org/en/latest/release-v7.0.0.html |
rthille
approved these changes
Mar 5, 2019
Contributor
rthille
left a comment
rthille
left a comment
There was a problem hiding this comment.
Looks reasonable. Not sure why you didn't go to PyPy 7.0. Also, is it worth testing against PyPy3.5 yet?
Contributor
Author
|
Good points, I will try out PyPy 7.0 and add PyPy3. Thank you for the review! |
Contributor
Author
|
It looks like Travis doesn't have PyPy 7.0. :'( I'll roll that bit back. |
Contributor
Big Sad :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've yet to find where Travis documents these things. This is cargo-culted from html5lib/html5lib-python#409.