Skip to content

Allow person data to be sent through the API#54

Open
skuro wants to merge 1 commit intocircleci:masterfrom
skuro:feature/add-person-tracking
Open

Allow person data to be sent through the API#54
skuro wants to merge 1 commit intocircleci:masterfrom
skuro:feature/add-person-tracking

Conversation

@skuro
Copy link
Copy Markdown
Contributor

@skuro skuro commented Sep 27, 2021

Fixes #53 by allowing a :person map to be passed through the Rollbar API call, without breaking any existing API contract

Fixes circleci#53 by allowing a `:person` map to be passed through the API
call, without breaking any existing API contract
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 27, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.16%. Comparing base (3ecd8cb) to head (bf911de).
⚠️ Report is 31 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   92.20%   89.16%   -3.05%     
==========================================
  Files           4        4              
  Lines         231      240       +9     
  Branches        5        5              
==========================================
+ Hits          213      214       +1     
- Misses         13       21       +8     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@marcomorain marcomorain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

I think we can modify make-rollbar to alwaya take a person argument.

I should probably write more docs now that more folks are using this library :)

url :- (s/maybe String)
custom :- (s/maybe {s/Any s/Any})]
custom :- (s/maybe {s/Any s/Any})
& [person :- {:id String
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make-rollbar is only called in one place, and it's private, so we should be able to make the new argument a required parameter, right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature request: person tracking

2 participants