Skip to content

ci: fix release-please wiring#140

Open
ashutosh-ukey wants to merge 1 commit intocirclefin:masterfrom
ashutosh-ukey:ci/fix-release-please-wiring
Open

ci: fix release-please wiring#140
ashutosh-ukey wants to merge 1 commit intocirclefin:masterfrom
ashutosh-ukey:ci/fix-release-please-wiring

Conversation

@ashutosh-ukey
Copy link
Contributor

Summary

The release workflow was checking needs.release-please.outputs.did-create-release, but Circle's shared conventional-commit-release workflow exposes release_created instead. This caused the npm-publish job to be skipped even after a release was created. This change updates the condition to use release_created so npm publishing follows the actual shared workflow output contract.

Changes

  • update .github/workflows/release.yml to gate npm-publish on needs.release-please.outputs.release_created
  • align the npm publish job with the same release signal already used by release-sbom

Validation

  • reviewed the failed release-please run 23267482209
  • confirmed the shared workflow contract exposes release_created
  • confirmed Circle internal docs reference release_created for downstream gating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants