Merged
Conversation
The conflicting errors and warnings from flake8 are already handled by ruff.
meshy
approved these changes
May 23, 2024
| rev: 5.13.2 | ||
| hooks: | ||
| - id: isort | ||
| - id: ruff |
Contributor
There was a problem hiding this comment.
I think we'd benefit from having ruff-format here too.
Contributor
There was a problem hiding this comment.
Oh, I forgot that we'd need to remove that too.
Yes, I think we should use ruff instead of black, but that can wait for another PR.
ulgens
added a commit
to ulgens/ccbv
that referenced
this pull request
Dec 13, 2025
ulgens
added a commit
to ulgens/ccbv
that referenced
this pull request
Dec 13, 2025
Already enabled as a ruff rule set Relates to classy-python#236
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This swaps out flake8 and isort for ruff. I've enabled a few rulesets that I tend to use everywhere. We might want to add more? There are a couple of commits after the swap, fixing errors brought up by it, all in the pyupgrade family.
One oddity I noticed was that the dev tooling, such as black/flake8/etc., is not installed outside of pre-commit, so to test these changes, I had to install ruff manually.