This repository was archived by the owner on May 6, 2020. It is now read-only.
ci: Update how journalctl gets the cc-proxy log#776
Merged
chavafg merged 1 commit intoclearcontainers:masterfrom Dec 6, 2017
Merged
ci: Update how journalctl gets the cc-proxy log#776chavafg merged 1 commit intoclearcontainers:masterfrom
chavafg merged 1 commit intoclearcontainers:masterfrom
Conversation
jodh-intel
approved these changes
Dec 6, 2017
|
kubernetes qa-passed 👍 |
|
lgtm
|
Now that the cc-proxy will not be a service, we need to use option -t in journalctl to get the logs from the proxy. Relates to: clearcontainers/runtime#835 clearcontainers/proxy#177 Fixes: clearcontainers#775 Signed-off-by: Salvador Fuentes <salvador.fuentes@intel.com>
chavafg
force-pushed
the
topic/fix_teardown
branch
from
d9b2f28 to
f63701a
Compare
|
kubernetes qa-passed 👍 |
mcastelino
pushed a commit
to mcastelino/tests
that referenced
this pull request
Jan 23, 2019
An early change slide in a stderr re-direct that broke the check in the good case as well. Fix that by moving the stderr redirect. Also, drop the chdir as it is not needed, and can fail in itself. Whilst here, improve the error message for when we do fail the dir check. Fixes: clearcontainers#776 Signed-off-by: Graham Whaley <graham.whaley@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the cc-proxy will not be a service, we need to use
option -t in journalctl to get the logs from the proxy.
Relates to:
clearcontainers/runtime#835
clearcontainers/proxy#177
Fixes: #775
Signed-off-by: Salvador Fuentes salvador.fuentes@intel.com