Skip to content

Enhance exception message in update_bulk_unique_0_u32_u64_u64 method#2441

Open
ch4r1ty wants to merge 2 commits intoclockworklabs:masterfrom
ch4r1ty:master
Open

Enhance exception message in update_bulk_unique_0_u32_u64_u64 method#2441
ch4r1ty wants to merge 2 commits intoclockworklabs:masterfrom
ch4r1ty:master

Conversation

@ch4r1ty
Copy link
Copy Markdown

@ch4r1ty ch4r1ty commented Mar 12, 2025

  • Improved the exception message in the update_bulk_unique_0_u32_u64_u64 method to provide more detailed information about the discrepancy between expected and actual row counts. This enhancement will aid in debugging and understanding issues related to insufficient rows during bulk updates.

Description of Changes

Improved the exception message in the update_bulk_unique_0_u32_u64_u64 method within the synthetic.cs file. The updated exception message now provides detailed information about the discrepancy between expected and actual row counts. This enhancement will assist in debugging and understanding issues related to insufficient rows during bulk updates.

API and ABI breaking changes

This change does not involve any API or ABI breaking modifications.

Expected complexity level and risk

Complexity Level: 1

This change is a simple string update and does not have complex interactions with existing or future code.

Testing

Completed Tests:

  • Verified that the exception message displays correctly when there are insufficient rows.
    Reviewer Tests:

  • Confirm that the exception message accurately reflects the expected and actual row count differences under various conditions.

- Improved the exception message in the `update_bulk_unique_0_u32_u64_u64` method to provide more detailed information about the discrepancy between expected and actual row counts. This enhancement will aid in debugging and understanding issues related to insufficient rows during bulk updates.
@bfops
Copy link
Copy Markdown
Collaborator

bfops commented Apr 4, 2025

Hey @ch4r1ty ! Thanks for opening this. Since the benchmarks are currently part of the main SpacetimeDB repo, we ask contributors to sign our Contributor License Agreement (CLA) before we merge their changes.

If you're willing to sign our CLA, could you send an email to cla@clockworklabs.io? After that, this PR LGTM 🙂 )

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 3, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ cloutiertyler
❌ ch4r1ty
You have signed the CLA already but the status is still pending? Let us recheck it.

@cloutiertyler cloutiertyler enabled auto-merge April 13, 2026 23:06
Copy link
Copy Markdown
Contributor

@cloutiertyler cloutiertyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial change, I'm going to approve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants