Skip to content

Allowed specifying timestamp literals in SQL#2842

Open
egormanga wants to merge 4 commits intoclockworklabs:masterfrom
egormanga:sql-timestamp-literal
Open

Allowed specifying timestamp literals in SQL#2842
egormanga wants to merge 4 commits intoclockworklabs:masterfrom
egormanga:sql-timestamp-literal

Conversation

@egormanga
Copy link
Copy Markdown
Contributor

@egormanga egormanga commented Jun 6, 2025

Currently, specifying a timestamp as an ISO-format string in SQL fails with:
Error: Unexpected type: (expected) String != (__timestamp_micros_since_unix_epoch__: I64) (inferred)

This PR allows specifying it (along with other, possibly future string literal-based types), as well as fixes the incorrect type order in the above error message (the inferred one should be from SQL, and the expected is the column SATS type).

API and ABI breaking changes

None.

Expected complexity level and risk

1.

Note for reviewers: this should NOT allow anything irrelevant, as parse() that we call still checks for the types to match.

Testing

  • Manual test case: INSERTing a timestamp column and SELECTing WITH comparing it.

@cloutiertyler
Copy link
Copy Markdown
Contributor

@egormanga the diff here seems to be unrelated to the PR. I'm assuming it's been done on another branch?

@egormanga
Copy link
Copy Markdown
Contributor Author

It is related, since it allows trying to parse the timestamp value from a string. Have you even tried running it or at least read the description where it is explained? :\

I loved contributing to Spacetime at first, but at this point it seems just plain disappointing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants