Draft
Conversation
…ter' into bfops/rust-smoketests-lib
bfops
commented
Mar 18, 2026
bfops
commented
Mar 18, 2026
| pub organization: Option<String>, | ||
| pub force: bool, | ||
| pub stdin_input: Option<&str>, | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
started refactoring to the builder pattern so we stop having a billion different versions of the publish function.
I would like to do this for several other parts of this lib as well, but it's not an imminent priority.
This reverts commit f143b04.
bfops
commented
Apr 13, 2026
Signed-off-by: Zeke Foppa <196249+bfops@users.noreply.github.com>
bfops
commented
Apr 13, 2026
|
|
||
| #[test] | ||
| fn test_http_redirect_to_disallowed_ip_is_blocked() { | ||
| require_local_server!(); |
Collaborator
Author
There was a problem hiding this comment.
I don't really understand how this test works, but it seems like given that we're spawning an extra server, this must only work for local servers
…SpacetimeDB into bfops/rust-smoketests-lib
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
A variety of small expansions/fixes to the smoketests lib.
Also, several of the tests were not working when
--serverwas passed, due to name collisions. Each test runs with its own identity, but if it tried to publish over an existing database, it would get an auth error. I have fixed the name collisions. However, the original python smoketests simply used random strings, where we currently use hardcoded names and/or hardcoded names with PID suffixes. This seems less robust and should potentially be changed.API and ABI breaking changes
None. Testing only.
Expected complexity level and risk
2
Testing