Build jemalloc with a larger page size#4766
Open
clockwork-labs-bot wants to merge 2 commits intomasterfrom
Open
Build jemalloc with a larger page size#4766clockwork-labs-bot wants to merge 2 commits intomasterfrom
clockwork-labs-bot wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JEMALLOC_SYS_WITH_LG_PAGE=16Context
Users on Linux/aarch64 can hit an immediate abort before any CLI work starts:
The reported reproducer was
spacetime loginon Fedora Asahi Remix 42 on Apple Silicon, but the crash happens during allocator init, so it is not specific to login.This switches from the earlier allocator fallback approach to the narrower fix John requested: build jemalloc with a larger configured page size.
Caveat
Cargo does not support target-specific
[env]config, so the repo-level fix uses workspace cargo config and applies to any local build of vendored jemalloc from this repo, not only Linux/aarch64.Testing
cargo check -p spacetimedb-cli -p spacetimedb-standalone -p spacetimedb-client-api