fix(cli): add confirmation prompt to spacetime delete#4772
Closed
euxaristia wants to merge 1 commit intoclockworklabs:masterfrom
Closed
fix(cli): add confirmation prompt to spacetime delete#4772euxaristia wants to merge 1 commit intoclockworklabs:masterfrom
spacetime delete#4772euxaristia wants to merge 1 commit intoclockworklabs:masterfrom
Conversation
euxaristia
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
|
|
`spacetime delete` previously deleted databases immediately with no confirmation. Add a y/N prompt before sending the delete request, skippable with `--yes`/`-y` for scripting. Closes clockworklabs#4679 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
euxaristia
force-pushed
the
fix/delete-confirmation-prompt
branch
from
edb0b8a to
b82d72e
Compare
Collaborator
|
Thank you for opening this! Closing in favor of #4770. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
y/Nconfirmation prompt beforespacetime deletesends the delete request, preventing accidental database destruction--yes/-yflag skips the prompt for scripting/CI useCloses #4679
Test plan
spacetime delete <db>— confirm prompt appears, answeringnabortsspacetime delete <db>— confirm prompt appears, answeringyproceeds with deletionspacetime delete <db> --yes— confirm prompt is skipped, deletion proceedsspacetime delete <db-with-children>— both the new prompt and the existing child-database warning appear🤖 Generated with Claude Code