Draft
Conversation
zjrgov
reviewed
Jan 5, 2026
zjrgov
left a comment
zjrgov
left a comment
There was a problem hiding this comment.
Apologies if I've missed it here or in the discussions otherwise but I was wondering: what sort of credentials are you using with the AWS CLI for this?
| --tag-filters Key="Instance GUID",Values="$service_instance_guid" \ | ||
| | jq -r '.ResourceTagMappingList[].ResourceARN' | grep -v replica ) | ||
|
|
||
| # get AWS instancea name from ARN |
There was a problem hiding this comment.
typo (non-blocking): on instances; vvv important, good thing I was curious about this PR so I could make this helpful feedback
Suggested change
| # get AWS instancea name from ARN | |
| # get AWS instances name from ARN |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
security considerations
[Note the any security considerations here, or make note of why there are none]