Add support for administrators_authorized_keys to SetUserSSHPublicKeysPlugin and UsersPlugin#171
Open
savchuk1985 wants to merge 2 commits intocloudbase:masterfrom
Open
Conversation
savchuk1985
changed the title
administrators_authorized_keys to SetUserSSHPublicKeysPlugin and UsersPlugin
…sPlugin see https://learn.microsoft.com/en-us/windows-server/administration/openssh/openssh_keymanagement#administrative-user Change-Id: Ieabb720af9a85a9bed2eb15ea11ef621ef7e1042
see https://learn.microsoft.com/en-us/windows-server/administration/openssh/openssh_keymanagement#administrative-user Change-Id: Id39cb6fbbf5d41a1202eebc9d47a385902404fce
savchuk1985
force-pushed
the
ssh-administrators-authorized-keys
branch
from
9b4485e to
4004584
Compare
| administrators_authorized_keys.extend(admin_public_keys) | ||
|
|
||
| if osutils.group_exists(ADMINISTRATORS): | ||
| program_data_dir = os.getenv("PROGRAMDATA", "C:\ProgramData") |
There was a problem hiding this comment.
Wouldn't it be better to not hardcode the system drive letter here, but get it through a SystemDrive environment variable too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #162.
Adds support for
administrators_authorized_keystoSetUserSSHPublicKeysPluginandUsersPlugin. See https://learn.microsoft.com/en-us/windows-server/administration/openssh/openssh_keymanagement#administrative-user for the details.Please note that the rule from the Win32-OpenSSH configuration only applies to the group that is literally called Administrators. Win32-OpenSSH does not check the system internationalization and does not use security identifiers for group matching.
Therefore, we only check for the presence of a group with the English name used in the Win32-OpenSSH configuration, and do nothing if the group is missing.