Skip to content

[AIENG-404] The plumbing command enhancements for alias and component…#1265

Open
kohsuke wants to merge 2 commits intomainfrom
AIENG-404
Open

[AIENG-404] The plumbing command enhancements for alias and component…#1265
kohsuke wants to merge 2 commits intomainfrom
AIENG-404

Conversation

@kohsuke
Copy link
Copy Markdown
Contributor

@kohsuke kohsuke commented Mar 26, 2026

… aggregation.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds new CLI capabilities to support alias updates and build “component” aggregation, along with accompanying tests and minor CLI plumbing updates.

Changes:

  • Introduces update alias command to point an alias at a build and wires the update command group into the main CLI.
  • Extends record build to accept repeated --component NAME=BUILD_OR_ALIAS options and sends components in the build payload.
  • Updates and adds tests to cover components payload behavior and alias update behavior (including fail-fast mode).

Reviewed changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
tests/commands/update/test_alias.py Adds coverage for update alias success and error/fail-fast behavior
tests/commands/record/test_build.py Updates expected build payloads to include components; adds new component-related tests
smart_tests/utils/commands.py Adds Command.UPDATE_ALIAS enum value for tracking
smart_tests/commands/update/alias.py Implements update alias command behavior
smart_tests/commands/update/init.py Adds update command group and registers alias subcommand
smart_tests/commands/record/build.py Adds --component option, validation, and includes components in build payload
smart_tests/args4p/typer/init.py Changes Exit to extend BaseException (to avoid broad except Exception swallowing)
smart_tests/main.py Registers update group in the top-level CLI

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

- Unused import statement
- Reject path traversal attack
Copy link
Copy Markdown
Contributor

@Konboi Konboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants