Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new CLI capabilities to support alias updates and build “component” aggregation, along with accompanying tests and minor CLI plumbing updates.
Changes:
- Introduces
update aliascommand to point an alias at a build and wires theupdatecommand group into the main CLI. - Extends
record buildto accept repeated--component NAME=BUILD_OR_ALIASoptions and sendscomponentsin the build payload. - Updates and adds tests to cover
componentspayload behavior and alias update behavior (including fail-fast mode).
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/commands/update/test_alias.py | Adds coverage for update alias success and error/fail-fast behavior |
| tests/commands/record/test_build.py | Updates expected build payloads to include components; adds new component-related tests |
| smart_tests/utils/commands.py | Adds Command.UPDATE_ALIAS enum value for tracking |
| smart_tests/commands/update/alias.py | Implements update alias command behavior |
| smart_tests/commands/update/init.py | Adds update command group and registers alias subcommand |
| smart_tests/commands/record/build.py | Adds --component option, validation, and includes components in build payload |
| smart_tests/args4p/typer/init.py | Changes Exit to extend BaseException (to avoid broad except Exception swallowing) |
| smart_tests/main.py | Registers update group in the top-level CLI |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Unused import statement - Reject path traversal attack
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… aggregation.