Parallelize chunk uploads in record tests for better throughput#1268
Open
Parallelize chunk uploads in record tests for better throughput#1268
Conversation
Use ThreadPoolExecutor to POST event chunks concurrently instead of sequentially. The first chunk is sent synchronously to handle no-build mode (where the response sets the session ID), then subsequent chunks are uploaded in parallel with up to 3 workers. This significantly reduces wall-clock time when uploading millions of test records by overlapping network I/O with parsing. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
When uploading millions of test records (e.g. with the raw profile), the
record testscommand is too slow because event chunks are posted sequentially. With the default chunk size of 1000, uploading 1M records requires ~1000 HTTP round-trips, each blocking until the response arrives. The main thread idles during network I/O instead of parsing the next chunk.What
Use
concurrent.futures.ThreadPoolExecutor(3 workers) to POST event chunks concurrently instead of sequentially:This overlaps network I/O with parsing and reduces wall-clock time by approximately 3x for large uploads.
Please Review Here
payload()(which mutatescount) runs only on the main thread.send()runs in worker threads but only readsself.session(set after the first sync call) and setsis_observation(same value every response).requests.Sessionis thread-safe for concurrent requests.