Add export/update FileCredentials support#220
Open
mvanini wants to merge 2 commits intocloudbees:masterfrom
Open
Add export/update FileCredentials support#220mvanini wants to merge 2 commits intocloudbees:masterfrom
mvanini wants to merge 2 commits intocloudbees:masterfrom
Conversation
Dohbedoh
approved these changes
Apr 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actually the script for credentials-migration doesn't fully support FileCredential type. That type of credential are exported as a SecretBytes (encrypted with master key of Jenkins source instance) and imported as SecretBytes generated by the already encrypted value...resulting in corrupted file.
I added a new Converter that handle the marshal/unmarshal operation of SecretBytes.
The file content is encoded in base64.