feat: allow dev server to run without building kumo first#176
Draft
danielrobertson wants to merge 1 commit intocloudflare:mainfrom
Draft
feat: allow dev server to run without building kumo first#176danielrobertson wants to merge 1 commit intocloudflare:mainfrom
danielrobertson wants to merge 1 commit intocloudflare:mainfrom
Conversation
Collaborator
|
@danielrobertson are you still working on this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
Running pnpm dev on a fresh clone (or after rm -rf packages/kumo/dist) failed with:
Cannot find module '@cloudflare/kumo/scripts/theme-generator/config'
This happened because vite-plugin-kumo-colors.ts imported from the package path, which resolves via package.json exports to
dist/scripts/theme-generator/config.js—a file that doesn't exist until the kumo package is built.
Additionally, after fixing that, another error appeared for @cloudflare/kumo/code which was missing from the HMR plugin's alias list.
Solution
package export. This matches the pattern already used elsewhere in the file (line 102-105 already referenced this path for file watching).
Test plan