Implement RFC-0027: Add max_route_options_size BOSH property#630
Open
rkoster wants to merge 2 commits intocloudfoundry:developfrom
Open
Implement RFC-0027: Add max_route_options_size BOSH property#630rkoster wants to merge 2 commits intocloudfoundry:developfrom
rkoster wants to merge 2 commits intocloudfoundry:developfrom
Conversation
Adds the cc.max_route_options_size BOSH property (default: 1024 bytes) to control the maximum allowed size of route options JSON payloads. - Add cc.max_route_options_size property to cloud_controller_ng job spec - Expose property via cloud_controller_internal BOSH link - Map property into cloud_controller_ng.yml.erb for api job - Map property into cloud_controller_ng.yml.erb for worker job (via link) - Include git-sourced gem directories in cloud_controller_ng package spec
rkoster
force-pushed
the
rfc-0027-route-options-size-limit
branch
from
a0d70cb to
99eb5b3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the
cc.max_route_options_sizeBOSH property to support the route options size limit implemented in cloudfoundry/cloud_controller_ng#4934. The property is propagated to the worker job via thecloud_controller_internalBOSH link, consistent with how other validation limits (e.g.max_labels_per_resource,max_annotations_per_resource) are shared across CC components.Changes
jobs/cloud_controller_ng/spec: Addedcc.max_route_options_sizeproperty (default: 1024) and exposed it in thecloud_controller_internallink's properties listjobs/cloud_controller_ng/templates/cloud_controller_ng.yml.erb: Maps the property to the CC configjobs/cloud_controller_worker/templates/cloud_controller_ng.yml.erb: Consumes the property via thecloud_controller_internallinkProperty
cc.max_route_options_size1024Related