Skip to content

add t-schoell to temp-ari-autoscaler-admins and Autoscaler approvers#1412

Closed
geigerj0 wants to merge 2 commits intocloudfoundry:mainfrom
geigerj0:patch-1
Closed

add t-schoell to temp-ari-autoscaler-admins and Autoscaler approvers#1412
geigerj0 wants to merge 2 commits intocloudfoundry:mainfrom
geigerj0:patch-1

Conversation

@geigerj0
Copy link
Copy Markdown
Contributor

@geigerj0 geigerj0 commented Jan 22, 2026

Problem

@t-schoell joined our internal SAP autoscaler team. Unfortunately, too many authorizations for our developer-on-duty shift, e.g. restarting GitHub Workflow runs, are coupled with being an Autoscaler approver.

Unfortunately, @t-schoell does not yet fulfill the requirements, as he is still quite new.

Solution

Add @t-schoell as an Autoscaler approver so that he can take over developer-on-duty shifts in the SAP autoscaler team.

@geigerj0 geigerj0 marked this pull request as ready for review January 22, 2026 14:03
@beyhan beyhan added the wg-ari label Jan 22, 2026
@beyhan beyhan requested review from Gerg and stephanme January 22, 2026 15:09
@beyhan
Copy link
Copy Markdown
Member

beyhan commented Jan 22, 2026

We will require two approvals (thumps up, +1 comment,...) from the @cloudfoundry/wg-app-runtime-interfaces-autoscaler-approvers because we have definitely more than four approvers in the area. Afterwards the WG leads should decide on this.

@geigerj0 geigerj0 changed the title add t-schoell to temp-ari-autoscaler-adminsand Autoscaler approvers add t-schoell to temp-ari-autoscaler-admins and Autoscaler approvers Jan 25, 2026
@stephanme
Copy link
Copy Markdown
Member

Please provide a list of your contributions. The script contributions-for-user.sh can help to create this list.

The regular requirements for a promotion from reviewer to approver are listed in ROLES.md#approver.

@stephanme
Copy link
Copy Markdown
Member

Closing for now as there was no update for 4 weeks. You can always re-open or create a new PR.

@stephanme stephanme closed this Feb 24, 2026
@github-project-automation github-project-automation Bot moved this from Inbox to Done in CF Community Feb 24, 2026
@t-schoell
Copy link
Copy Markdown
Contributor

Hello @stephanme,
I now have the following contributions. I was not able to run the script you provided, so here are my collected merged PRs:

I hope this is sufficient. As mentioned, the approver role is crucial for the work as DoD in respect of handling the renovate Bot issues.

@t-schoell
Copy link
Copy Markdown
Contributor

Btw: The [contributions-for-user.sh]
fails for me with this:

sh contributions-for-user.sh t-schoell "App Runtime Interfaces"
Parsing working group metadata...
Gathering GH events...
Gathering contributions for the 'App Runtime Interfaces: Autoscaler' area...
Error: bad file '-': yaml: line 7: found unexpected document indicator
Error: bad file '-': yaml: line 3: mapping values are not allowed in this context
yq --version
yq (https://github.com/mikefarah/yq/) version v4.52.4

@t-schoell
Copy link
Copy Markdown
Contributor

I could not re-open this PR, I openend a new one here:
#1451

We can either merge this or the other

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants