Skip to content

CF PCAP#1092

Merged
geofffranks merged 2 commits intocloudfoundry:developfrom
sap-contributions:maxmoehl/cf-pcap
Feb 23, 2026
Merged

CF PCAP#1092
geofffranks merged 2 commits intocloudfoundry:developfrom
sap-contributions:maxmoehl/cf-pcap

Conversation

@maxmoehl
Copy link
Member

@maxmoehl maxmoehl commented Dec 23, 2025

Summary

This is the implementation of RFC 0048 / #1076.

In its current state the PR cannot be merged (and will be a draft PR for now) as there are two hacks left which have to be cleaned up:

  1. I've just checked-in the libpcap release source code from the release tar-ball. I'd prefer to add libpcap as a submodule and consume that as it's also easy to bump but the autogen.sh was causing issues down the line. Either we add the libpcap release tar-ball as a blob or fix the autogen.
  2. The archiver needs to support xattrs, this is a minor change that just needs to be upstreamed and then dropped from this PR.

The PR can be built into a release and deployed. To test the feature you can SSH into an app that was deployed after the change has been deployed and then observe traffic like this:

/tmp/lifecycle/cf-pcap -interface lo -filter "port 8080" | tcpdump -r - -X

This will print the HTTP traffic to the app process in plain-text to your terminal (while being safely escaped by tcpdump which is not the case for raw output from cf-pcap).

I'm looking for some early feedback on the changes so feel free to leave a review!

Backward Compatibility

Breaking Change? No

Disclaimer: The development of this PR was supported by Claude Code.

@maxmoehl
Copy link
Member Author

maxmoehl commented Jan 7, 2026

cloudfoundry/archiver#74 got merged and consumed in diego-release, dropped the commit and force-pushed. Now I only need to fix the BOSH blob.

@ameowlia
Copy link
Member

@maxmoehl , @geofffranks, and I chatted in a zoom. The outcome was...

  • make it optional
  • adds docs
  • ass testing (in cats?)
  • get blob uploaded (ci link)
  • split the commits so the vendor is in its own commit

@maxmoehl
Copy link
Member Author

  • make it optional

done and done

  • adds docs

added to docs/

  • ass testing (in cats?)

Depends on this being merged.

Draft PR opened

  • split the commits so the vendor is in its own commit

deps and code

@maxmoehl
Copy link
Member Author

maxmoehl commented Feb 4, 2026

I've adjusted the code to use the libpcap from the bosh blob and rebased on the latest develop. Next, I'll borrow an environment to throw this on to test it all together one more time.

@maxmoehl maxmoehl marked this pull request as ready for review February 12, 2026 12:13
@maxmoehl
Copy link
Member Author

There's one more change we need on the CI repo: cloudfoundry/wg-app-platform-runtime-ci#119

@github-project-automation github-project-automation bot moved this from Inbox to Pending Merge | Prioritized in Application Runtime Platform Working Group Feb 18, 2026
@geofffranks geofffranks merged commit 157d785 into cloudfoundry:develop Feb 23, 2026
1 check passed
@github-project-automation github-project-automation bot moved this from Pending Merge | Prioritized to Done in Application Runtime Platform Working Group Feb 23, 2026
@domdom82
Copy link
Contributor

domdom82 commented Feb 25, 2026

ass testing (in cats?)

please don't, cats don't like that.

@maxmoehl maxmoehl deleted the maxmoehl/cf-pcap branch February 25, 2026 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

4 participants