Disables watching the private key file for updates#12
Merged
pivotal-david-osullivan merged 1 commit intomainfrom Apr 5, 2023
Merged
Disables watching the private key file for updates#12pivotal-david-osullivan merged 1 commit intomainfrom
pivotal-david-osullivan merged 1 commit intomainfrom
Conversation
dmikusa
approved these changes
Apr 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, both the certificate and private key file were watched for changes and upon a change to either, both values were read and used to update the KeyManager. This caused an infrequent race-condition (see #8) where a mix of old and new data was left in the KeyManager until the next key/cert rotation. This resulted in apps that used client cert authentication to receive
bad_certificateerrors from the server side.This PR disables the Filewatcher & callback for the private key file, as changes to the certificate file alone should indicate the presence of new key & cert values since the cert will be updated after the key. Both new values will therefore be updated to the KeyManager upon a cert file change.
Fixes #8
Supersedes #10 & #9