Add VCAP_SERVICES_FILE_PATH support#1150
Open
kiril-keranov wants to merge 3 commits intocloudfoundry:feature/go-migrationfrom
Open
Add VCAP_SERVICES_FILE_PATH support#1150kiril-keranov wants to merge 3 commits intocloudfoundry:feature/go-migrationfrom
kiril-keranov wants to merge 3 commits intocloudfoundry:feature/go-migrationfrom
Conversation
Contributor
|
this seems like a great feature and should be added to all the other buildpacks as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for
VCAP_SERVICES_FILE_PATH, more info can be found here.The feature usage demand is increasing as the current limitation of 130KB maximum content for
VCAP_SERVICESis quite insufficient in various cases. The maximum content withVCAP_SERVICES_FILE_PATHis increased to 1MB.The feature can be used when an application applies the following in the manifest:
Note:
VCAP_SERVICESandVCAP_SERVICES_FILE_PATHare mutually exclusive as can be seen in the cloud controller code