Skip to content

Reuse installed ginkgo and use cleaner binary check#717

Open
jorbaum wants to merge 2 commits intocloudfoundry:mainfrom
jorbaum:minor-test-script-improvements
Open

Reuse installed ginkgo and use cleaner binary check#717
jorbaum wants to merge 2 commits intocloudfoundry:mainfrom
jorbaum:minor-test-script-improvements

Conversation

@jorbaum
Copy link
Copy Markdown
Contributor

@jorbaum jorbaum commented Feb 23, 2026

Description

While working on cloudfoundry/go-loggregator#79 I found two things that I found worth adding to the test scripts:

  • reuse ginkgo instead of recompiling every time, same as we are already doing with golangci-lint
  • cleaner check for binary removing three lines of code ;)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

@jorbaum jorbaum force-pushed the minor-test-script-improvements branch from 8f021ec to 5ed3da6 Compare April 23, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

1 participant