Conversation
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Apache HttpComponents references to align with the HttpClient 5 / HttpCore 5 packages, removing legacy (4.x) constants and presence checks.
Changes:
- Update the runtime class-presence check in
OAuth2ContextExtensionto look fororg.apache.hc.client5...RequestConfig. - Replace usage of the legacy
org.apache.http.protocol.HTTPconstant withorg.apache.hc.core5.http.HttpHeaders.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| uaa/src/test/java/org/cloudfoundry/identity/uaa/oauth/client/test/OAuth2ContextExtension.java | Updates the HttpComponents enablement check to use the HttpClient 5 RequestConfig class name. |
| server/src/main/java/org/cloudfoundry/identity/uaa/util/UaaHttpRequestUtils.java | Removes the legacy HttpCore 4 HTTP import and switches keep-alive header iteration to HttpHeaders.KEEP_ALIVE. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
duanemay
approved these changes
Apr 12, 2026
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Apache dependency
Found during working on OpenSAML 5 update. With opensaml 5 we do not have any furhter library deps for apache 4 clients thus this fails