Conversation
Fir #issue 3835 Ony do the issuer validation in custom zones, but not in UAA zone
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts identity zone configuration validation to allow the default UAA zone to start successfully when using a legacy signing-key setup, by skipping issuer/signing-key coupling validation for that zone (per issue #3835).
Changes:
- Skip issuer-vs-signing-key validation when
zone.isUaa()is true. - Keep the existing validation behavior for all non-UAA (custom) zones.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../main/java/org/cloudfoundry/identity/uaa/zone/GeneralIdentityZoneConfigurationValidator.java
Show resolved
Hide resolved
cf-foundation-community-automation
bot
moved this to Inbox
in Foundational Infrastructure Working Group
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
.../java/org/cloudfoundry/identity/uaa/zone/GeneralIdentityZoneConfigurationValidatorTests.java
Show resolved
Hide resolved
.../java/org/cloudfoundry/identity/uaa/zone/GeneralIdentityZoneConfigurationValidatorTests.java
Show resolved
Hide resolved
duanemay
approved these changes
Apr 14, 2026
github-project-automation
bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
github-project-automation
bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fir #issue 3835
Ony do the issuer validation in custom zones, but not in UAA zone