Remove use of reserved keyword arguments as an argument name#6
Open
mike-lang wants to merge 2 commits intocloudhead:masterfrom
Open
Remove use of reserved keyword arguments as an argument name#6mike-lang wants to merge 2 commits intocloudhead:masterfrom
mike-lang wants to merge 2 commits intocloudhead:masterfrom
Conversation
This parameter named arguments is obscured by the special arguments object anyway. Including it in the function signature does nothing except make the code violate strict mode
|
Please merge this PR so that vargs does not break in strict_mode |
|
Please merge this. Changing |
|
please accept this Pull Req. your argument cause error to other lib |
|
+1 on merging this PR |
|
please merge |
|
for those looking to deal with this issue since it doesn't seem to be maintained anymore, see https://www.npmjs.com/package/patch-package |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This argument is obscured by the arguments object anyway. It is the only strict mode violation in the module. Making this one line change allows the module to load in strict mode while making no change to the functionality.
I also created a package.json as best I could with appropriate values pulled from the repo's
README.mdso I could bump the version number