Improve permission_callback of Cloudinary Rest API endpoints #1135
+78
−34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1134 and this topic.
Approach
permission_callbackto all endpoints created by the plugin.wp_restnonce.'permission_callback' => '__return_true'work with the new approach ('permission_callback' => array( 'Cloudinary\REST_API', 'validate_request').rest_test_rest_api_connectivityusestrue(isolated in a separate method) because this is a Rest API check only.QA notes
admin.php?page=cloudinaryand ensureui-stateandstatsAJAX requests resolve.daemon_watcherandrun_queuemethods ofclass-cron.phpcloudinary_cron_systemandcloudinary_cron_scheduletheme options.page=cloudinary§ion=cron_systemNext Runcolumn)