feat(greenhouse): add plugin preset detail view #1442
Conversation
🦋 Changeset detectedLatest commit: dd35f2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
apps/greenhouse/src/components/admin/PluginPresetDetail/Overview/index.tsx
Fixed
Show fixed
Hide fixed
|
taymoor89
force-pushed
the
1324-plugin-preset-detail
branch
from
eb511f3 to
7fa8a94
Compare
edda
left a comment
edda
left a comment
There was a problem hiding this comment.
I like it! Two comments (see below)
| <Section> | ||
| <PluginPresetStats pluginPreset={pluginPreset} /> | ||
| </Section> | ||
| <Section> |
There was a problem hiding this comment.
To save some vertical space and utilize the horizontal space better please change the layout here so that the BasicInformation section and the ClusterSelector section are rendered in a two-column layout next to each other.
| const ready = isPluginReady(plugin) | ||
|
|
||
| return ( | ||
| <DataGridRow key={plugin.metadata?.name} onClick={() => {}}> |
There was a problem hiding this comment.
Will the onClick navigate to the detail view of this plugin instance in the future? If yes, then this is fine, if not please remove the empty onClick as it leads users to believe that the rows are interactive.
There was a problem hiding this comment.
yes that onClick is an entry point for the plugin instance detail page.
2 participants
Summary
This PR implements plugin preset details view. That can be accessed at
/admin/plugin-presets/:pluginPresetName.Changes Made
Related Issues
Screenshots (if applicable)
Testing Instructions
pnpm ipnpm TASKChecklist
PR Manifesto
Review the PR Manifesto for best practises.