refactor: consolidate CEL filter into ShootSelector struct#34
Merged
mikolajkucinski merged 3 commits intomainfrom Feb 18, 2026
Merged
refactor: consolidate CEL filter into ShootSelector struct#34mikolajkucinski merged 3 commits intomainfrom
mikolajkucinski merged 3 commits intomainfrom
Conversation
64696ea to
ef8f1b2
Compare
- Restructure ShootSelector with nested LabelSelector and Expression fields - Move CEL filtering to watch-level predicates in shoot controller - Add ExcludedShoots/EffectiveShootCount status for observability - Fix ListShoots to support MatchExpressions via LabelSelectorAsSelector On-behalf-of: @SAP mikolaj.kucinski@sap.com
ef8f1b2 to
c500fb0
Compare
uwe-mayer
requested changes
Feb 13, 2026
Contributor
uwe-mayer
left a comment
There was a problem hiding this comment.
Some suggestions on status collection, nice work!
- Rename ClusterStatus to ShootStatus with Enum=Onboarded;Failed;Excluded - Remove ExcludedShootStatus, merge into ShootStatus with Excluded status - Rename Clusters to Shoots, TotalShoots to TotalTargetShoots - Remove secret cleanup for CEL-excluded shoots - Simplify CEL predicate using predicate.NewPredicateFuncs pattern On-behalf-of: @SAP mikolaj.kucinski@sap.com
5d9ca25 to
7e69945
Compare
uwe-mayer
reviewed
Feb 16, 2026
uwe-mayer
requested changes
Feb 16, 2026
On-behalf-of: @SAP mikolaj.kucinski@sap.com
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
uwe-mayer
approved these changes
Feb 17, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shootSelectorandshootFilterinto a singleshootSelectorstruct withlabelSelectorandexpressionfieldsstatus.shootswithExcludedstatus alongside onboarded/failed shootsLabelSelectorAsSelectorto support bothmatchLabelsandmatchExpressionsClusterStatustoShootStatuswithEnum=Onboarded;Failed;Excludedstatus.clusterstostatus.shootsandstatus.totalShootCounttostatus.totalTargetShootCountCareInstructionBreaking change:
shootSelectorfield structure changedMigrate existing CareInstructions with